Skip to content

Fix MWC: fix global chain type race and use auth for mwc713.mwc.mw#1271

Open
sneurlax wants to merge 16 commits into
stagingfrom
fix/mwc
Open

Fix MWC: fix global chain type race and use auth for mwc713.mwc.mw#1271
sneurlax wants to merge 16 commits into
stagingfrom
fix/mwc

Conversation

@sneurlax
Copy link
Copy Markdown
Member

@sneurlax sneurlax commented Mar 3, 2026

2 fixes in one, one which fixes syncing and another which fixes a crash bug

Comment thread lib/wallets/wallet/impl/mimblewimblecoin_wallet.dart Outdated
Copy link
Copy Markdown
Collaborator

@danrmiller danrmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on linux.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 26, 2026

Codecov Report

❌ Patch coverage is 8.10811% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.93%. Comparing base (db0c225) to head (47bac5f).
⚠️ Report is 23 commits behind head on staging.

Files with missing lines Patch % Lines
...gs_view/manage_nodes_views/add_edit_node_view.dart 0.00% 37 Missing ⚠️
...b/wallets/wallet/impl/mimblewimblecoin_wallet.dart 0.00% 27 Missing ⚠️
lib/utilities/test_mwcmqs_connection.dart 0.00% 3 Missing ⚠️
lib/models/type_adaptors/node_model.g.dart 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1271      +/-   ##
===========================================
+ Coverage     4.82%    4.93%   +0.11%     
===========================================
  Files         1064     1064              
  Lines       107921   108025     +104     
===========================================
+ Hits          5208     5332     +124     
+ Misses      102713   102693      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

danrmiller
danrmiller previously approved these changes Apr 26, 2026
Copy link
Copy Markdown
Collaborator

@danrmiller danrmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this as it improves the current state of the app, mwc will now work with this merged.

Comment thread lib/wallets/wallet/impl/mimblewimblecoin_wallet.dart Outdated
Comment thread lib/wallets/wallet/impl/mimblewimblecoin_wallet.dart Outdated
Comment thread lib/wallets/wallet/impl/mimblewimblecoin_wallet.dart Outdated
@sneurlax sneurlax marked this pull request as draft April 27, 2026 00:41
@sneurlax sneurlax marked this pull request as ready for review April 27, 2026 00:48
@sneurlax
Copy link
Copy Markdown
Member Author

Closes #1303 now too

`dart format $(git diff --name-only origin/staging...HEAD | grep '\.dart$')`
@sneurlax sneurlax marked this pull request as draft April 27, 2026 02:29
@sneurlax
Copy link
Copy Markdown
Member Author

sneurlax commented Apr 27, 2026

Have to recheck that

  • users can change the password in settings if mwc changes the password on their node

@sneurlax sneurlax marked this pull request as ready for review May 13, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants